Update performance data unit of measure #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The performance data has the wrong unit, all are marked as "c" which is a continuous counter. Per Nagios guidelines, load averages should have no unit, and memory/storage should be in KB/GB/B units.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance data has the wrong unit, all are marked as "c" which is a continuous counter. Per Nagios guidelines, load averages should have no unit, and memory/storage should be in KB/GB/B units.
When using pnp4nagios, the graphs are incorrectly rendered with the continuous counter UOM, this patch fixes the issue.
Sample perf data before change:
...| /volume1=4998c /volume2=2211cAfter change:
...|/volume1=4998GB /volume2=2211GB