- Upgrade helmet to v4.6.0 #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Install nocache becaue helmet.noCache() removed and changed to separate plugin - Implement noCache() instead of helmet.noCache() - Change default options of current implementation - Checked and debug the app after upgrade
…w5983-update-helmet-4.6.0 * 'master' of https://github.com/weseek/growi: (358 commits) fix version write tar command with blob bugfix update workflow files add packages update docs fix label and encode spaces in Linker class remove getLinkForPreview method hide scrollbar of .grw-tag-labels when editing update docs hide footer on edit hide Fab on edit update README update ci settings update .env files ignore dist update ci.yml to upload artifact update jest settings fix ci.yml update ci settings ... # Conflicts: # packages/app/package.json # yarn.lock
yarn.lock : - Resolve by use master head state (append new code) packages/app/package.json: - Using current branch head and adjust based on merged master state - Remove "growi-plugin-attachment-refs" line because it has been changed to "@growi/plugin-attachment-refs" commit log = 204188f - Remove "growi-plugin-lsx" line because it has been changed to "@growi/plugin-lsx" commit log = 1787cdd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note
noCache has been removed from the new version (4) of helmet.
helmetjs/helmet#215
Declaring the options (new!)
There are different default options for helmet 3 and 4.
We adjusted the options to use helmet 4 based on the helmet 3 default options.
(Without the adjustment, it causes a security error when a user accesses the app.)
Helmet 3 default options:
https://github.com/helmetjs/helmet/tree/d75a4a34002bcd66d06723b175c50105fd4e4e11
Helmet 4 default options:
https://github.com/helmetjs/helmet