Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: User group link in admin page #8855

Merged
merged 40 commits into from
Jul 24, 2024
Merged

Conversation

kazutoweseek
Copy link
Contributor

@kazutoweseek kazutoweseek commented May 29, 2024

Copy link

changeset-bot bot commented May 29, 2024

⚠️ No Changeset found

Latest commit: 7b7160d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kazutoweseek kazutoweseek changed the title imprv: Edit icon add imprv: Add underline and icon Jun 7, 2024
@kazutoweseek kazutoweseek changed the title imprv: Add underline and icon imprv: Management screen design change Jun 10, 2024
<span className="text-decoration-underline">{group.name}</span>
{(hoveredIndex === index) && (<span className="material-symbols-outlined px-2 py-0">edit</span>
)}
</button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOM 構造について

DOM 構造的に Link の中に button があるのは違和感。

親コンテナの中に Link と button を子供として並列に入れて、
親コンテナに対する hover で button の表示・非表示をコントロールしたらいいと思う。
PageCreateButton あたりが参考になるはず。

ステート管理について

index を保持するのはあまりスマートではないので、ここは切り出して別コンポーネントにしよう。
このファイル内に定義してしまって構わない。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これが考慮されていないと思う。
以下を別コンポーネントに切り出して index を props で渡す、という実装になるんじゃないかな。

    <button
      className="btn btn-link btn-edit-groups text-secondary py-0"
      type="button"
      key={group._id}
    >
      <span className="material-symbols-outlined pe-2 pt-2">group</span>
      <span className="text-decoration-underline">{group.name}</span>
      <span className={`material-symbols-outlined px-2 py-0 ${hovereditem === item ? '' : 'opacity-0'}`}>edit</span>
    </button>

Copy link

reg-suit bot commented Jul 24, 2024

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei changed the title imprv: Management screen design change imprv: User group link in admin page Jul 24, 2024
@yuki-takei yuki-takei merged commit 259eda5 into master Jul 24, 2024
27 of 28 checks passed
@yuki-takei yuki-takei deleted the imprv/140677-145630-new-design branch July 24, 2024 10:20
@github-actions github-actions bot mentioned this pull request Jul 24, 2024
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants