Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: Update favicon #8957

Merged
merged 5 commits into from
Jul 11, 2024
Merged

support: Update favicon #8957

merged 5 commits into from
Jul 11, 2024

Conversation

satof3
Copy link
Contributor

@satof3 satof3 commented Jul 11, 2024

Task

https://redmine.weseek.co.jp/issues/149830

Summary

  • favicon の更新
  • SVG化
    • ダークモード切り替えに対応
  • SVG化に伴い不要なサイズ別のfavicon apple-icon を削除
  • ms-icon および /browserconfig.xml の削除
image image

後続ストーリー

参考

https://smarthr.design/basics/meta/favicon/

@satof3 satof3 requested a review from yuki-takei July 11, 2024 05:15
@satof3 satof3 self-assigned this Jul 11, 2024
Copy link

changeset-bot bot commented Jul 11, 2024

⚠️ No Changeset found

Latest commit: 64276d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

reg-suit bot commented Jul 11, 2024

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei merged commit f6f5653 into master Jul 11, 2024
28 of 29 checks passed
@yuki-takei yuki-takei deleted the support/149830-update-favicon branch July 11, 2024 17:24
@github-actions github-actions bot mentioned this pull request Jul 11, 2024
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants