Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Some OIDC authentication settings not being applied #9000

Conversation

WNomunomu
Copy link
Contributor

@WNomunomu WNomunomu commented Jul 30, 2024

タスク

https://redmine.weseek.co.jp/issues/149969

概要

  • OIDC 認証用の設定が反映されない問題を修正しました。

変更点

  • discoverしたoidcIssuerのmetadataを書き換えるのではなく、discoverしたoidcissuerからmetadataを引き抜き、そのmetadataを用いて新たにnewOidcIssuerを作成しnewOidcIssuerのClientを使用するようにしました。

セルフチェック

  • コンフリクト解消したか
  • 余計なコードは残っていないか
  • 適切にメモ化したか
  • 責務の問題はクリアしているか
  • CIは通っているか
  • PRの内容は適切にかけているか

Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: e3163de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

reg-suit bot commented Jul 30, 2024

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei changed the title fix: the problem of OIDC authentication settings not being applied fix: Some OIDC authentication settings not being applied Jul 30, 2024
@yuki-takei yuki-takei merged commit d71d124 into master Jul 30, 2024
28 of 29 checks passed
@yuki-takei yuki-takei deleted the fix/149968-149969-the-problem-of-OIDC-authentication-settings-not-being-applied branch July 30, 2024 20:06
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants