Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move OpenAI related files to features directly #9237

Conversation

miya
Copy link
Member

@miya miya commented Oct 11, 2024

@miya miya requested a review from yuki-takei October 11, 2024 06:59
@miya miya self-assigned this Oct 11, 2024
Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 9c8980f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author

@miya miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

インラインコメントがある部分以外は path の変更による差分です


const validator: ValidationChain[] = [
body('threadId').optional().isString().withMessage('threadId must be string'),
];

return [
accessTokenParser, loginRequiredStrictly, validator, apiV3FormValidator,
accessTokenParser, loginRequiredStrictly, certifyAiService, validator, apiV3FormValidator,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

certifyAiService middleware を追加

const logger = loggerFactory('growi:routes:apiv3:openai:chat');
import { certifyAiService } from './middlewares/certify-ai-service';

const logger = loggerFactory('growi:routes:apiv3:openai:thread');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chat -> thread に変更


const logger = loggerFactory('growi:routes:apiv3:openai:chat');
const logger = loggerFactory('growi:routes:apiv3:openai:message');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chat -> message に変更

@@ -40,7 +41,7 @@ export const postMessageHandlersFactory: PostMessageHandlersFactory = (crowi) =>
];

return [
accessTokenParser, loginRequiredStrictly, validator, apiV3FormValidator,
accessTokenParser, loginRequiredStrictly, certifyAiService, validator, apiV3FormValidator,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

certifyAiService middleware を追加

@miya miya merged commit 9048b87 into feat/openai-vector-searching Oct 15, 2024
7 checks passed
@miya miya deleted the imprv/155101-move-open-ai-related-files-to-features-directly branch October 15, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant