Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Automatic thread deletion using node-cron #9256

Merged
merged 13 commits into from
Oct 18, 2024
Merged

feat: Automatic thread deletion using node-cron #9256

merged 13 commits into from
Oct 18, 2024

Conversation

miya
Copy link
Member

@miya miya commented Oct 17, 2024

Task

  • #155005 [RAG] 使われなくなった Thread が自動で削除される
    • #155763 thread が自動で削除できる

@miya miya requested a review from yuki-takei October 17, 2024 09:25
@miya miya self-assigned this Oct 17, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fb767d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

miya
miya commented Oct 18, 2024
View reviewed changes
apps/app/package.json Show resolved Hide resolved
apps/app/src/features/openai/server/services/thread-deletion-cron.ts
this.openaiService = openaiService;

// Executed at 0 minutes of every hour
const cronSchedule = '0 * * * *';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一時間に一回実行

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

環境変数でカスタムできても良いかも

apps/app/src/features/openai/server/services/thread-deletion-cron.ts
private async executeJob(): Promise<void> {
// Must be careful of OpenAI's rate limit
// Delete up to 100 threads per hour
await this.openaiService.deleteExpiredThreads(DELETE_LIMIT);
Copy link
Member Author

@miya miya Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • OpenAI の rate limit に考慮して最大100件まで thread を削除する
  • いっきに何千件も削除してしまった場合、メインのナレッジアシスタントに影響が出てしまう可能性があるため

apps/app/src/features/openai/server/services/thread-deletion-cron.ts

}

export default ThreadDeletionCronService;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuestionnaireCronService を参考にして実装しました。
https://github.com/weseek/growi/blob/df8e58f4486c03c1f7bad22b9645f468e315a915/apps/app/src/features/questionnaire/server/service/questionnaire-cron.ts

mergify bot added a commit that referenced this pull request Oct 18, 2024
@mergify
Merge of #9256
18514df
@mergify mergify bot mentioned this pull request Oct 18, 2024
Closed
15 tasks
@yuki-takei
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Oct 18, 2024
@mergify
Merge of #9256
724e198
@mergify mergify bot mentioned this pull request Oct 18, 2024
Closed
15 tasks
@mergify mergify bot merged commit cc279f4 into feat/155690-implement-openai-thread-model Oct 18, 2024
9 checks passed
@mergify mergify bot deleted the feat/155763-automatic-thread-deletion branch October 18, 2024 14:32
@github-actions github-actions bot mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuki-takei yuki-takei yuki-takei approved these changes

Assignees

@miya miya

Labels
flag/exclude-from-changelog type/feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miya @yuki-takei