Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GROWI AI Next #9492

Open
wants to merge 281 commits into
base: master
Choose a base branch
from
Open

feat: GROWI AI Next #9492

wants to merge 281 commits into from

Conversation

miya
Copy link
Member

@miya miya commented Dec 17, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1402441

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

miya and others added 28 commits December 18, 2024 03:56
@miya
Refactor PageSelectModal (2)
4ec6dbc
@miya
impl SelectedPageList
4b939dd
@miya
Selected pages are not duplicated
29c6277
@miya
memorization
f6c934a
@miya
impl
e8d1667
@yuki-takei
Merge pull request #9496 from weseek/feat/159149-open-pageselectmodal…
9bff6da 
…-when-page-add-button-is-clicked

feat: Open PageSelectModal when page add button is clicked
@miya
Merge branch 'master' into feat/growi-ai-next
43cbf79
@miya
Add checkbox to include subordinated pages in modal
254109d
@miya
Merge branch 'feat/growi-ai-next' into feat/159152-ai-assistant-model
9081d95
@miya
not optional
c0c9bc0
@miya
Revert "Add field (isDeleted)"
5f4ba68 
This reverts commit 6a505a4.
@miya
Refactor AiAssistant model to use vectorStore reference and export Ve…
eafecf9 
…ctorStore interface
@miya
Add option to include subordinated pages in page selection modal
d754820
@miya
rm debug log
5714a18
@miya
Add grantedUsers field to AiAssistant model for user-specific sharing
a6f79e0
@yuki-takei
Merge pull request #9505 from weseek/imprv/159329-modify-page-select-…
f3b97fb 
…modal

feat: Modify PageSelectModal
@miya
Merge branch 'feat/growi-ai-next' into feat/159152-ai-assistant-model
d63af50
@miya
Merge branch 'master' into feat/growi-ai-next
568a4e6
@miya
Add assistant description and update icon in AiChatModal component
90bf8f8
@miya
Create SelectedPageList.tsx
820784a
@miya
Merge branch 'feat/growi-ai-next' into feat/159152-ai-assistant-model
815deee
@miya
Rename learningScope to ownerAccessScope in AiAssistant model for cla…
10c7773 
…rity
@miya
Rename AiAssistantSharingScope to AiAssistantShareScope for consistency
f661d11
@miya
Update enum reference for shareScope to use AiAssistantShareScope
752768a
@miya
Add pagePaths property to AiAssistant model for enhanced functionality
0775170
@miya
Update AiAssistantManagementModal to enhance user instructions and ad…
52db218 
…d memo functionality
@miya
Add remove functionality for selected pages in AiAssistantManagementM…
c19d6a9 
…odal
@miya
onClickOpenPageSelectModalButton -> clickOpenPageSelectModalHandle
99796c1
miya and others added 29 commits February 6, 2025 04:52
@miya
Added the ability to remove assistants from the UI.
4877314
@miya
Change the target for firing clickOpenThreadHandler
0294677
@miya
fix styles
5014902
@miya
add delete thread button
2595282
@miya
fix styles
b632d68
@miya
clean code & add todo
b554ad7
@miya
Use useSWRImmutable
c677155
@miya
Add guest user check to AiAssistant component
fc98415
@miya
Impl updateAiAssistantsFactory
8b2dea8
@miya
Impl updateAiAssistant
aa00de4
@miya
Add validator
9e4fc23
@miya
Add AiAssistantTree.module.scss
6e9e8cf
@miya
Merge pull request #9617 from weseek/feat/160587-implement-ai-assista…
dd90563 
…nt-list-view

feat: Implement AiAssistantTree
@miya
Merge branch 'feat/growi-ai-next' into feat/161504-implement-api-to-u…
f84816d 
…pdate-ai-assistant
@miya
fix arg
51ba4d6
@miya
Commonize validator
3aa3317
@miya
clean code
5da9400
@miya
Commonize interfaces
9d0c61a
@miya
AiAssistant Update Logic Implementation
ccd7c78
@miya
imprv naming
224b848
@miya
impl isDeepEquals
e0b74c2
@miya
If accessScope, pagePathPatterns, grantedGroupsForAccessScope have no…
3d297a2 
…t changed, do not build VectorStore
@miya
Refactor for document return
ba759e9
@miya
Add error handling for uninitialized OpenAI service in AI assistant r…
50206db 
…outes
@miya
Use http-errors
7022542
@miya
fix comment
a134c92
@miya
Relocate isDeepEquals
a62f4e5
@yuki-takei
Merge branch 'master' into feat/growi-ai-next
66e720f
@miya
Merge pull request #9630 from weseek/feat/161504-implement-api-to-upd…
1402441 
…ate-ai-assistant
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 7, 2025
View reviewed changes
apps/app/src/features/openai/server/routes/middlewares/upsert-ai-assistant-validator.ts

// check if the value is a grob pattern path
if (value.includes('*')) {
return isGrobPatternPath(value) && isCreatablePage(value.replace('*', ''));

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This replaces only the first occurrence of '*'.

Copilot Autofix AI 3 days ago

To fix the problem, we need to ensure that all occurrences of the asterisk (*) character in the value string are replaced. This can be achieved by using a regular expression with the global flag (g). Specifically, we should replace value.replace('*', '') with value.replace(/\*/g, '').

Suggested changeset 1
apps/app/src/features/openai/server/routes/middlewares/upsert-ai-assistant-validator.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/apps/app/src/features/openai/server/routes/middlewares/upsert-ai-assistant-validator.ts b/apps/app/src/features/openai/server/routes/middlewares/upsert-ai-assistant-validator.ts
--- a/apps/app/src/features/openai/server/routes/middlewares/upsert-ai-assistant-validator.ts
+++ b/apps/app/src/features/openai/server/routes/middlewares/upsert-ai-assistant-validator.ts
@@ -43,3 +43,3 @@
       if (value.includes('*')) {
-        return isGrobPatternPath(value) && isCreatablePage(value.replace('*', ''));
+        return isGrobPatternPath(value) && isCreatablePage(value.replace(/\*/g, ''));
       }
EOF
@@ -43,3 +43,3 @@
if (value.includes('*')) {
return isGrobPatternPath(value) && isCreatablePage(value.replace('*', ''));
return isGrobPatternPath(value) && isCreatablePage(value.replace(/\*/g, ''));
}
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miya @yuki-takei