Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to calculate diagnostics when conf_int is 'none'. #79

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

efiring
Copy link
Collaborator

@efiring efiring commented Jan 10, 2020

Closes #78.
The smoke-test has been extended to catch this.

Closes wesleybowman#78.
The smoke-test has been extended to catch this.
@rsignell-usgs
Copy link
Contributor

rsignell-usgs commented Jan 14, 2020

@efiring , wow, it's really good to not calculate the errors if you don't need them. Setting conf_int='none' reduced my compute time from 25 min to 2 min!
Is this waiting for a review or can we merge?

@efiring efiring merged commit 45525f7 into wesleybowman:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

solve failing when conf_int='none'
2 participants