Skip to content

Commit

Permalink
PARQUET-561: Add destructor to PIMPL
Browse files Browse the repository at this point in the history
Without this destuctor, the SerializedFile class cannot be destructed and leaks memory.

Author: Uwe L. Korn <uwelk@xhochy.com>

Closes apache#77 from xhochy/destructor-for-pimpl and squashes the following commits:

0f80966 [Uwe L. Korn] Add destructor to PIMPL
  • Loading branch information
xhochy authored and wesm committed Sep 2, 2018
1 parent 3e9f761 commit 40926e5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cpp/src/parquet/file/reader.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ class ParquetFileReader {
public:
// Forward declare the PIMPL
struct Contents {
virtual ~Contents() {}
// Perform any cleanup associated with the file contents
virtual void Close() = 0;

Expand Down

0 comments on commit 40926e5

Please sign in to comment.