test: resolve issues with virtual file system running on Windows plat…

…forms detecting a case insensitive OS when memfs is always case sensitive
wessberg · Aug 4, 2023 · 45aeda6 · 45aeda6
1 parent 351bf26
commit 45aeda6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml
@@ -11,7 +11,7 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest]
-        node: [16.14.0, 17, 18, 19, 20]
+        node: [16.14.0, 18, 20]
 
     steps:
       - name: Checkout code
@@ -46,7 +46,7 @@ jobs:
     strategy:
       matrix:
         os: [macos-latest, ubuntu-latest]
-        node: [16.14.0, 17, 18, 19, 20]
+        node: [16.15.1, 18, 20]
 
     steps:
       - name: Checkout code

diff --git a/src/service/cache/resolve-cache/resolve-cache.ts b/src/service/cache/resolve-cache/resolve-cache.ts
@@ -86,7 +86,7 @@ export class ResolveCache {
 		}
 
 		// Resolve the file via Typescript, either through classic or node module resolution
-		const {resolvedModule} = this.resolveModuleName(typescript, id, parent, compilerOptions, moduleResolutionHost) as {
+		const {resolvedModule} = this.resolveModuleName(typescript, id, path.normalize(parent), compilerOptions, moduleResolutionHost) as {
 			resolvedModule: ExtendedResolvedModule | undefined;
 		};
 

diff --git a/test/util/create-typescript-system.ts b/test/util/create-typescript-system.ts
@@ -70,7 +70,6 @@ export function createTypeScriptSystem({
 	executingFileName = path.urlToFilename(executingFileName);
 	const typescript = _typescript as TSExtended;
 	const wildcardCharCodes = [42, 63];
-	const platform = os.platform();
 	const byteOrderMarkIndicator = "\uFEFF";
 
 	function statSync(p: string) {
@@ -124,10 +123,6 @@ export function createTypeScriptSystem({
 	 * Taken directly from TypeScript internals
 	 */
 	function isFileSystemCaseSensitive() {
-		// win32\win64 are case insensitive platforms
-		if (platform === "win32") {
-			return false;
-		}
 		// If this file exists under a different case, we must be case-insensitive.
 		return !fileExists(swapCase(executingFileName));
 	}