Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor token and make consts simple #128

Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat: refactor token and make consts simple #128

merged 1 commit into from
Dec 6, 2024

Conversation

ozline
Copy link
Member

@ozline ozline commented Dec 6, 2024

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

refactor

这个 PR 做了什么 / 我们为什么需要这个 PR?

  1. 删去 Hertz 的 jwt 实现,改由自定义 token 实现
  2. token 使用 Ed25519 加密
  3. etc

(可选)这个 PR 解决了哪个/些 issue?

对 Reviewer 预留的一些提醒

尽快通过

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 110 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/api/main.go 0.00% 53 Missing ⚠️
api/handler/api/user_service.go 0.00% 43 Missing ⚠️
config/config.go 0.00% 10 Missing ⚠️
api/router/api/middleware.go 0.00% 2 Missing ⚠️
internal/classroom/syncer/workqueue.go 0.00% 1 Missing ⚠️
pkg/cache/paper/util.go 0.00% 1 Missing ⚠️
@@           Coverage Diff            @@
##            main    #128      +/-   ##
========================================
- Coverage   2.76%   2.69%   -0.08%     
========================================
  Files        144     144              
  Lines      22394   22484      +90     
========================================
- Hits         620     606      -14     
- Misses     21739   21842     +103     
- Partials      35      36       +1     
Flag Coverage Δ
unittest 2.69% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/handler/api/class_room_service.go 0.00% <ø> (ø)
api/handler/api/url_service.go 0.00% <ø> (ø)
internal/classroom/syncer/workqueue.go 0.00% <0.00%> (ø)
pkg/cache/paper/util.go 0.00% <0.00%> (ø)
api/router/api/middleware.go 0.00% <0.00%> (ø)
config/config.go 0.00% <0.00%> (ø)
api/handler/api/user_service.go 0.00% <0.00%> (ø)
cmd/api/main.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@ozline ozline merged commit ffe8612 into main Dec 6, 2024
7 of 9 checks passed
@ozline ozline deleted the new-token branch December 6, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant