fix: api.common and api.version logic error , hard-coding in tests #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FantasyRL
changed the title
|
目前未解决的问题：internal/course/service/get_course_list_test.go会调用到logger，导致make test识别到error |
|
你这个 pr 谁来看？ |
等会我尝试修一下ci |
jiuxia211
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
自查 PR 结构
PR 标题符合这个格式: <type>(optional scope): <description>
此 PR 标题的描述以用户为导向，足够清晰，其他人可以理解。
我已经对所有 commit 提供了签名（GPG 密钥签名、SSH 密钥签名）
这个 PR 属于强制变更/破坏性更改
这个 PR 的类型是什么？
fix
这个 PR 做了什么 / 我们为什么需要这个 PR？
这个pr修正了在api层common与version服务在出错返回时多返回了内部错误
并且修复了在测试中出现的硬编码问题
(可选)这个 PR 解决了哪个/些 issue？
对 Reviewer 预留的一些提醒
这个测试还移除了一个与log有关的test，在#143中会被重新添加