add develop.md #77
Merged
add develop.md #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchwarzSail
requested review from
jiuxia211,
ozline and
a team
as code owners
|
结构图那边，网关是从etcd里获取服务对应的地址，然后去请求微服务的，网关 和 server 之间应该是有交互的，结构图没有体现这点 |
|
面向新手的文档 需要新手来看，可以让 @拽奇奇 看看 |
你这个没有@到，而且我估计他没有配置邮件通知，可能得私聊一下 |
主要是我不知道他github id ，我的意思也是私聊一下 |
FantasyRL
reviewed
Nov 5, 2024
docs/develop.md
Outdated
Comment on lines
106
to
118
| #### 三层架构设计 | ||
| 显式将代码分为三层，分别是 Handler 层、服务层和数据层 | ||
|
|
||
| 以 `classroom` 为例 | ||
| ```bash | ||
| ├── handler.go # handler 层 | ||
| ├── pack # 用于打包返回给 api 的数据, 只由 handler 调用 | ||
| │ └── classroom.go | ||
| ├── service | ||
| ├── get_room.go # 服务函数实现 | ||
| ├── get_room_test.go # 对应函数的单测 | ||
| └── service.go # 服务的定义与实现 | ||
| ``` |
|
@SmilingSea 你可以看一下这份文档有没有哪里写的不行的，如果没啥问题的话周五就给他合入了 |
|
好的，这两天正在看这个文档，目前看起来没啥问题 |
|
@renbaoshuo cc |
renbaoshuo
reviewed
Nov 30, 2024
逗号的问题应该解决了，但是句号和冒号我实在不知道怎么配置，有时间帮我改改罢🌹 |
|
你在搞什么，怎么行都被截断了？ 我这个 review 是让你人工改的，不是 prettier 规则（ |
我还以为是直接用 prettier💦 |
SchwarzSail
force-pushed
the
add_develop.md
branch
from
3f5140f to
a6d84ac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #77 +/- ##
======================================
Coverage ? 2.75%
======================================
Files ? 144
Lines ? 22484
Branches ? 0
======================================
Hits ? 620
Misses ? 21829
Partials ? 35
Flags with carried forward coverage won't be shown. Click here to find out more. |
renbaoshuo
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
写到后面变成流水账了，帮我改改罢