requests: support a list of requests and no-session support #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a modified approach from #97 to address the review comments. |
twilfredo
commented
Aug 7, 2024
alistair23
requested changes
Aug 7, 2024
This extends the `request` command to allow the user to specify a list of requests that shall be ',' seperated. request get-version,get-capabilities,negotiate-algorithms requests with subcommands can be specified as follows: request get-version,get-measurement[index=1,raw-bitsream] Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
This adds a new argument `no-session`, allowing the user to send an SPDM request(s) without establishing a session prior. That is, directly issue only the requests specified in the order in which they are specified to the responder. Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
twilfredo
force-pushed
the
wilfred/add-isolated-reqs-3
branch
from
d386c41 to
299cb69
Compare
Added a two tests cases that cover a range of positive and negative inputs. Let me know if the coverage is ok |
alistair23
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.