Fix rocksdb6 segfault #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert change of 'util: Fix occurances where back() might be called on an empty string' for `zenfs_tool_backup()`. Otherwise test/utils/0040_backup.sh segfaults when building ZenFS with RocksDB 6.29.fb (c++11). Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com> Signed-off-by: Hans Holmberg <hans.holmberg@wdc.com>
yhr
force-pushed
the
fix_rocksdb6_segfault
branch
from
e418c9f to
a7289c9
Compare
Thanks @aravind-wdc ! Great to get this sorted, now the nightly rocksdb 6 tests will pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util: Fix segfault when doing a backup with an empty backup_path
Revert change of 'util: Fix occurances where back() might be called on an
empty string' for
zenfs_tool_backup().Otherwise test/utils/0040_backup.sh segfaults when building ZenFS with
RocksDB 6.29.fb (c++11).