This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Remove _deprecated_scope_block on AssociationRelation
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/active_record/mass_assignment_security/association_relation.rb
Outdated
Show resolved
Hide resolved
foxlance
force-pushed
the
fix/remove_deprecated_scope_block_on_association_relation
branch
from
2024afd to
73bcc12
Compare
foxlance
force-pushed
the
fix/remove_deprecated_scope_block_on_association_relation
branch
from
73bcc12 to
1efbf6f
Compare
|
PR that makes the original change in behaviour - rails/rails#29301 was merged on June 28, 2017. Was merged before Rails 5.1.3 but I think was only released for 5.2.0 (rails/rails#33387). PR which removes the scoping block - rails/rails#33394 was merged on July 19, 2018. Would be included in Rails 5.2.1 I think that lets keep the |
|
@westonganger Done! Let me know if you find anything else worth addressing. |
|
@foxlance you added the scoping back for all Rails versions. We want the scoping block to be removed for Rails 5.2+. |
|
@westonganger Is the recent commit what you have in mind? |
|
Merged. Thanks for your contribution. |
|
v1.8.0 is now released which contains this fix. |
avit
added a commit
to avit/protected_attributes_continued
that referenced
this pull request
Mar 24, 2021
Fixes a regression from westonganger#21 where the scoping block was removed.
avit
added a commit
to avit/protected_attributes_continued
that referenced
this pull request
Mar 24, 2021
Fixes a regression from westonganger#21 where the scoping block was removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses the
NoMethodError: undefined method _deprecated_scope_block for ActiveRecord::AssociationRelationerror one might encounter when using.first_or_create, and possibly.first_or_initializeafter awhereclause on an association, e.g.This bug is specific to Rails 6.1.x with protected_attributes_continued v1.7.0. Downgrading to protected_attributes_continued v1.6.0 works if one is not after any specific 1.7.0 features.
This fix is inspired by rails/rails@255a7ef.