Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content - Text-level Modifiers - Created Example Pages #2211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SebastianBurke
Copy link
Contributor

Related to WET-401

@SebastianBurke SebastianBurke temporarily deployed to github-ci July 21, 2023 23:06 — with GitHub Actions Inactive
@duboisp duboisp added the Query: Project item Part of a github project label Sep 21, 2023
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline change request.

In summary:

  • Need to reorganize the page where each style do have their own section
  • Expand each style associated with "text-*"
  • Remove the text style related to the color because they are demoed elsewhere.
  • Reuse/copy the example for the stretch link from the wet-boew utilities page.

Regarding the text alignment, take out the example from this page and move it inside your page. Note that you may need to adjust the heading according to your page structure. See the technique here for more info: https://www.w3.org/WAI/WCAG21/Techniques/html/H42

May be it could help you to view and test those web page by using the Github pages. Let me know when you will be available, I will show it. It should take only 5 min.

common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Mar 6, 2024

Oh wait, Your PR change are interfering with the merge commit 19e9137. Please remove it and you will need to create a new commit to replace it and it is possible that you will need to reapply your changes.

For example, I don't see the "Overview" heading in my local test copy.

@Garneauma or @GormFrank can help you with that.

@SebastianBurke
Copy link
Contributor Author

I think Ive resolved it!

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed and tested locally,
See the requested change and please apply the similar change to the French example

common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
common/text-level-modifiers/text-level-modifiers-en.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: Review completed, changes requested
Development

Successfully merging this pull request may close these issues.

3 participants