-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content - Text-level Modifiers - Created Example Pages #2211
base: master
Are you sure you want to change the base?
Content - Text-level Modifiers - Created Example Pages #2211
Conversation
5037ce6
to
b4d7d61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the inline change request.
In summary:
- Need to reorganize the page where each style do have their own section
- Expand each style associated with "text-*"
- Remove the text style related to the color because they are demoed elsewhere.
- Reuse/copy the example for the stretch link from the wet-boew utilities page.
Regarding the text alignment, take out the example from this page and move it inside your page. Note that you may need to adjust the heading according to your page structure. See the technique here for more info: https://www.w3.org/WAI/WCAG21/Techniques/html/H42
- https://github.com/wet-boew/GCWeb/blob/master/common/colour/colour-en.html#L164-L211
- https://github.com/wet-boew/GCWeb/blob/master/common/colour/colour-fr.html#L164-L211
May be it could help you to view and test those web page by using the Github pages. Let me know when you will be available, I will show it. It should take only 5 min.
Oh wait, Your PR change are interfering with the merge commit 19e9137. Please remove it and you will need to create a new commit to replace it and it is possible that you will need to reapply your changes. For example, I don't see the "Overview" heading in my local test copy. @Garneauma or @GormFrank can help you with that. |
980210e
to
b4d7d61
Compare
b4d7d61
to
26c4958
Compare
I think Ive resolved it! |
26c4958
to
5b9ff59
Compare
5b9ff59
to
7a0542f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed and tested locally,
See the requested change and please apply the similar change to the French example
7a0542f
to
7c42939
Compare
Related to WET-401