GC Home Page: Reduced Doormats and added all services button #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrahimMahadi
temporarily deployed
to
github-ci
GitHub Actions
Inactive
|
@duboisp This PR is ready for review |
duboisp
requested changes
Oct 21, 2024
BrahimMahadi
force-pushed
the
gc-homepage-doormats
branch
from
d5735fc
to
4be728b
Compare
BrahimMahadi
had a problem deploying
to
github-ci
GitHub Actions
Failure
BrahimMahadi
force-pushed
the
gc-homepage-doormats
branch
from
4be728b
to
77292ed
Compare
BrahimMahadi
had a problem deploying
to
github-ci
GitHub Actions
Failure
duboisp
requested changes
Oct 21, 2024
BrahimMahadi
force-pushed
the
gc-homepage-doormats
branch
from
77292ed
to
8ceb8c9
Compare
BrahimMahadi
had a problem deploying
to
github-ci
GitHub Actions
Failure
BrahimMahadi
force-pushed
the
gc-homepage-doormats
branch
from
8ceb8c9
to
80f992a
Compare
BrahimMahadi
had a problem deploying
to
github-ci
GitHub Actions
Failure
BrahimMahadi
force-pushed
the
gc-homepage-doormats
branch
from
80f992a
to
03ab5ef
Compare
BrahimMahadi
had a problem deploying
to
github-ci
GitHub Actions
Failure
BrahimMahadi
force-pushed
the
gc-homepage-doormats
branch
from
03ab5ef
to
94b1179
Compare
BrahimMahadi
had a problem deploying
to
github-ci
GitHub Actions
Failure
BrahimMahadi
force-pushed
the
gc-homepage-doormats
branch
from
94b1179
to
cd57816
Compare
BrahimMahadi
temporarily deployed
to
github-ci
GitHub Actions
Inactive
BrahimMahadi
force-pushed
the
gc-homepage-doormats
branch
from
cd57816
to
736d0fa
Compare
BrahimMahadi
temporarily deployed
to
github-ci
GitHub Actions
Inactive
duboisp
requested changes
Oct 22, 2024
BrahimMahadi
force-pushed
the
gc-homepage-doormats
branch
from
736d0fa
to
ce452f0
Compare
BrahimMahadi
temporarily deployed
to
github-ci
GitHub Actions
Inactive
Garneauma
force-pushed
the
gc-homepage-doormats
branch
from
ce452f0
to
c3ff595
Compare
Garneauma
force-pushed
the
gc-homepage-doormats
branch
from
c3ff595
to
d9e4459
Compare
duboisp
requested changes
Oct 22, 2024
Garneauma
force-pushed
the
gc-homepage-doormats
branch
from
d9e4459
to
f5e3afa
Compare
duboisp
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
This code state is approved from a functional point of view. I reviewed and tested locally. We can use that state to proceed with the implementation of the interim solution on Canada.ca
I did saved a snapshot here: https://github.com/duboisp/GCWeb/tree/pr2434-approved-snapshot
Documentation still required prior to merge
duboisp
requested changes
Oct 22, 2024
Garneauma
force-pushed
the
gc-homepage-doormats
branch
from
f5e3afa
to
f93bf89
Compare
duboisp
modified the milestones:
v16.0.0,
Ready for review / Check WIP for moving it forward
duboisp
approved these changes
Nov 5, 2024
ouafaaetta
modified the milestones:
Ready for review / Check WIP for moving it forward,
v15.7.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes modifications for the GC home page to reduce number of Doormats and to add All Services button for DTO A/B testing
General checklist