Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fxevent.Run to registered events #130

Closed
wants to merge 2 commits into from
Closed

Add fxevent.Run to registered events #130

wants to merge 2 commits into from

Conversation

mikelsr
Copy link
Contributor

@mikelsr mikelsr commented Jul 11, 2023

Running ww start with fx 1.20.0 panics because we don't recognize the *fxevent.Run case in runtime.go:261. We should only merge this after updating the fx dependency.

@mikelsr mikelsr requested a review from lthibault July 11, 2023 14:15
@mikelsr
Copy link
Contributor Author

mikelsr commented Jul 11, 2023

I went ahead and updated fx

@lthibault
Copy link
Collaborator

I think this is covered by #126. Closing optimistically, but feel free to re-open if needed.

@lthibault lthibault closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants