Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iostream #97

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Remove iostream #97

merged 1 commit into from
Mar 29, 2023

Conversation

lthibault
Copy link
Collaborator

The iostream package was initially intended for applications requiring byte streams. However, such applications ended up being uncommon. Moreover iostream was unable to provide concurrent read/write to streams, and would block until the stream was actually closed, rendering it broken for the use-cases that actually did arise.

Not worth the trouble 😄

@lthibault lthibault added the enhancement New feature or request label Mar 29, 2023
@lthibault lthibault self-assigned this Mar 29, 2023
Copy link
Contributor

@aratz-lasa aratz-lasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lthibault
Copy link
Collaborator Author

Re-running CI. Looks like a transient failure.

@lthibault lthibault merged commit 0700dc1 into master Mar 29, 2023
@lthibault lthibault deleted the enhance/rm-iostream branch March 29, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants