Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionSheet 的menus,actions 应该允许传入自定className #51

Closed
p2227 opened this issue Mar 22, 2016 · 4 comments
Closed

ActionSheet 的menus,actions 应该允许传入自定className #51

p2227 opened this issue Mar 22, 2016 · 4 comments

Comments

@p2227
Copy link

p2227 commented Mar 22, 2016

我看了一下源代码

<div key={idx} {...others} className={className}>{label}</div>

这里唯独排除了className,似乎需要有像 #17 那样的处理

@progrape
Copy link
Collaborator

ActionSheet 有什么场景需要传入 classname 控制样式不?

@p2227
Copy link
Author

p2227 commented Mar 23, 2016

@progrape 是一个选择的菜单,用来标识当前用户选中的那个选项。比如字典项是1,2,3,用户当前选中的是2,那么弹出的时候希望2是高亮的用来提醒用户。

@progrape
Copy link
Collaborator

ActionSheet 并没有对某些项进行高亮的设计,都是并列的操作,所以不太推荐对某些项进行特殊处理。所以这个需求暂时 hold 住吧,如果有更多的场景需求,再考虑加入~

@p2227
Copy link
Author

p2227 commented Mar 23, 2016

哦,好的

@n7best n7best closed this as completed Mar 24, 2016
progrape added a commit that referenced this issue Apr 28, 2016
* #58, patched searchbar, add iconSize for toast #62, change weui dependency to 0.4.1 (#63)

* update `weui` version

* update react version and move to peerDependencies (#66)

1. react 升级到 v15,并且引入了新的版本规范。
    @see https://facebook.github.io/react/blog/2016/02/19/new-versioning-scheme.html

2. 不同版本的 react 会冲突,把依赖写到 peerDependencies 更合适一点。参考其他
    react 相关的库,如 react-redux.

* fix extra comma in package.json

* 修复 package.son 依赖
1. 补充依赖 jsdom
2. npm 对依赖 history 顺序做了调整

* #68 Cell* 增加支持传入自定义 className

* #51 ActionSheet 的 menus 和 actions 增加支持传入自定义 className
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants