-
-
Notifications
You must be signed in to change notification settings - Fork 205
Update Filecoin chain configuration #103
Conversation
🦋 Changeset detectedLatest commit: 3dfaf48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a path changeset and export the new chains from the packages/chains/src/index.ts
file.
Also, looks like the Glif block explorer doesn't follow EIP-3091. Would be great if the url
could be a base URL so folks can add on different paths (e.g. /address
, /tx
). Right now, with the query param at the end, this won't work by default. Seems like switching to Filescan or another could be the way to go (e.g. https://calibration.filscan.io
and https://hyperspace.filscan.io
).
export const filecoinCalibration: Chain = { | ||
id: 314159, | ||
name: 'Filecoin Calibration', | ||
network: 'filecoin-calibration', | ||
nativeCurrency: { | ||
decimals: 18, | ||
name: 'testnet filecoin', | ||
symbol: 'tFIL', | ||
}, | ||
rpcUrls: { | ||
default: { http: ['https://api.calibration.node.glif.io/rpc/v1'] }, | ||
public: { http: ['https://api.calibration.node.glif.io/rpc/v1'] }, | ||
}, | ||
blockExplorers: { | ||
default: { name: 'Glif', url: 'https://explorer.glif.io/?network=calibration' }, | ||
}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const filecoinCalibration: Chain = { | |
id: 314159, | |
name: 'Filecoin Calibration', | |
network: 'filecoin-calibration', | |
nativeCurrency: { | |
decimals: 18, | |
name: 'testnet filecoin', | |
symbol: 'tFIL', | |
}, | |
rpcUrls: { | |
default: { http: ['https://api.calibration.node.glif.io/rpc/v1'] }, | |
public: { http: ['https://api.calibration.node.glif.io/rpc/v1'] }, | |
}, | |
blockExplorers: { | |
default: { name: 'Glif', url: 'https://explorer.glif.io/?network=calibration' }, | |
}, | |
} | |
export const filecoinCalibration = { | |
id: 314_159, | |
name: 'Filecoin Calibration', | |
network: 'filecoin-calibration', | |
nativeCurrency: { | |
decimals: 18, | |
name: 'testnet filecoin', | |
symbol: 'tFIL', | |
}, | |
rpcUrls: { | |
default: { http: ['https://api.calibration.node.glif.io/rpc/v1'] }, | |
public: { http: ['https://api.calibration.node.glif.io/rpc/v1'] }, | |
}, | |
blockExplorers: { | |
default: { name: 'Glif', url: 'https://explorer.glif.io/?network=calibration' }, | |
}, | |
} as const satisfies Chain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tmm, thank you for the feedback!
Actually, Glif does support the EIP-3091 standard:
- https://explorer.glif.io/calibration/address/t01/
- https://explorer.glif.io/tx/bafy2bzaceayqt5cfkcgmse4ubezbfh2nl2336tmklengcxohtf5mrynalqoum/?network=calibration
Although currently there is no support for the /block
and /token
routes.
@tmm thanks for getting this over the finish line. Out of curiosity, what's the motivation for replacing Glif with Filscan a calibration / hyperspace explorer? Glif does support the EIP-3091 standard where Filscan doesn't:
Also I'm working on the Glif tools, so would like to know if there is anywhere we can do better! |
My mistake, thought it didn't work. Feel free to submit a new PR! |
Description
eth_
RPC methods.glif
key was misspelled in theblockExplorers
object for HyperspacenetAdditional Information