This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
feat: add ledger connector #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sort connector lists and some properties in alphabetical order
- remove `infuraId` from the connector options
- use the # symbol instead of the private keyword
- move Connect Kit initialization to `#getConnectKit`
- replace `#connectKitPromise` with `#connectKit`, and instead of
assigning it in the constructor, make it optional and assign it
inside `#getConnectKit`
- optionaly get chainId as a parameter when called by getProvider
since we need to pass it to connectKit.checkSupport
- instead of passing the `infuraId` build the rpc from the chain list
- fixes in `connect()`
- replace the `getAccount` call in connect with a request for
`eth_requestAccounts`
- add `chainId` and rename create parameter on `getProvider` for
consistency with ither connectors
- now calls `#getConnectKit` passing `chainId` instead of
just resolving the Connect Kit promise
- replace request for `eth_requestAccounts` with one for
`eth_accounts` in `getAccount` and call it from
`this.isAuthorized()`
- add `chainId` argument to `getSigner` and pass it to `getProvider`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Ledger connector that makes use of the Ledger Connect Kit to either show the Ledger Connect extension on Safari if installed, guide the user to install it if supported, or allow them to directly connect to Ledger Live through Wallet Connect on other platforms.
Let me know if there are any other changes needed. It seems that the docs and playground will be kept on the main wagmi repo but they reference the connectors.
This PR is based on #3, so the changes will be reduced after that one is merged.
Additional Information