This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
fix add more to avoid wallet impersonation #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 88cb471 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
tmm
reviewed
Apr 16, 2023
packages/connectors/src/metaMask.ts
Outdated
Comment on lines
56
to
62
| if (ethereum.isCoinbaseWallet) return | ||
| if (ethereum.isBitKeep) return | ||
| if (ethereum.isMathWallet) return | ||
| if (ethereum.isOkxWallet || ethereum.isOKExWallet) return | ||
| if (ethereum.isOneInchIOSWallet || ethereum.isOneInchAndroidWallet) return | ||
| if (ethereum.isOpera) return | ||
| if (ethereum.isRabby) return | ||
| if (ethereum.isRainbow) return | ||
| if (ethereum.isTally) return | ||
| if (ethereum.isTrust || ethereum.isTrustWallet) return | ||
| if (ethereum.isZerion) return |
There was a problem hiding this comment.
The intention of this check is to not be exhaustive and only to filter out options that try to appear as MetaMask. Just checking that all these injected providers meet that criteria?
There was a problem hiding this comment.
I've rechecked these providers and made some changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add more wallet flags to avoid wallet impersonation.
Additional Information
Your ENS/address: