Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dchain #2354

Merged
merged 8 commits into from
Jun 24, 2024
Merged

add dchain #2354

merged 8 commits into from
Jun 24, 2024

Conversation

oleksiivinogradov
Copy link
Contributor

@oleksiivinogradov oleksiivinogradov commented Jun 2, 2024


PR-Codex overview

The focus of this PR is to add a new chain called Dchain and its testnet version with configurations and definitions.

Detailed summary

  • Added dchain and dchainTestnet chains
  • Updated index.ts to export new chains
  • Created definitions for dchain and dchainTestnet with configurations

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 2, 2024

@oleksiivinogradov is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Jun 2, 2024

🦋 Changeset detected

Latest commit: e232f57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

bun.lockb Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess u can add it to .gitignore for better future PRs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change.

all done, can u approve?

@jxom
Copy link
Member

jxom commented Jun 9, 2024

I can't seem to find any information about this chain? Where can I see more about it?

@oleksiivinogradov
Copy link
Contributor Author

I can't seem to find any information about this chain? Where can I see more about it?

Sure.
DChain - blockchain for games and studios.

🔗 Deployment support with go-to-market strategy. With an average revenue of $85k per month from our games, 135+ strategic partnerships, and 16 committed projects, DChain unlocks endless opportunities. Benefit from our expert team's go-to-market strategy, unique liquidity system, and low transaction fees, while accessing our exclusive market tailored for crypto and blockchain projects.

Website: https://www.dchain.foundation/
Whitepaper: https://docs.openbisea.com/dexstudio/d-chain/d-chain

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reverted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be removing the bun.lockb file – just reverting it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be removing the bun.lockb file – just reverting it.

done

@jxom
Copy link
Member

jxom commented Jun 22, 2024

Just need to resolve the conflict, sorry. We migrated from Bun to pnpm, so we can actually remove the bun.lockb file now 😅

@oleksiivinogradov
Copy link
Contributor Author

Just need to resolve the conflict, sorry. We migrated from Bun to pnpm, so we can actually remove the bun.lockb file now 😅

I must remove and push?
Or anybody from team can do it? 🤣😂

@oleksiivinogradov
Copy link
Contributor Author

Just need to resolve the conflict, sorry. We migrated from Bun to pnpm, so we can actually remove the bun.lockb file now 😅

done ))))

@jxom jxom merged commit b8fc0dc into wevm:main Jun 24, 2024
2 of 3 checks passed
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants