fix(react,vue): useWriteContract value #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9ce5380 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -46 B (-0.01%) Total Size: 826 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3984 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 280 280
Lines 19624 19623 -1
Branches 681 678 -3
=======================================
Hits 19020 19020
+ Misses 594 592 -2
- Partials 10 11 +1 ☔ View full report in Codecov by Sentry. |
|
More changes needed in Viem, will re-open this later. |
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/typescript@5.4.2 |
tmm
commented
May 24, 2024
| @@ -62,7 +62,7 @@ jobs: | |||
| timeout-minutes: 5 | |||
| strategy: | |||
| matrix: | |||
| typescript-version: ['5.0.4', '5.1.6', '5.2.2', 'latest'] | |||
| typescript-version: ['5.0.4', '5.1.6', '5.2.2', '5.3.3', '5.4.5'] | |||
tmm
commented
May 24, 2024
Comment on lines
+52
to
+53
| // TODO: Should use `UnionOmit<..., 'chain'>` on `viem_WriteContractParameters` result instead | ||
| // temp workaround that doesn't affect runtime behavior for for https://github.com/wevm/wagmi/issues/3981 |
There was a problem hiding this comment.
Needs to be addresses in Viem first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useWriteContract().writeContractvaluenot inferred correctly whenconfigset up with chain that has formatters/serializers (e.gbase)This TS Playground illustrates the issue well. Fixes #3981.