Handle "type" that contain a single-element array #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philsturgeon Any concerns about this PR?.. |
| @@ -4,7 +4,7 @@ const convert = require('../'); | |||
| const should = require('should'); | |||
| const getSchema = require('./helpers').getSchema; | |||
|
|
|||
| ['basic', 'address', 'calendar'].forEach(test => { | |||
| ['basic', 'address', 'calendar', 'single-type-arrays'].forEach(test => { | |||
There was a problem hiding this comment.
These examples were taken from JSON Schema and were not meant to be the home for specific tests.
Maybe this test file would be a better home for testing this functionality? https://github.com/wework/json-schema-to-openapi-schema/blob/master/test/invalid_types.test.js
philsturgeon
suggested changes
Jul 23, 2018
There was a problem hiding this comment.
I think this PR highlights an existing bug in this package.
Changing that would be appreciated, while we're here.
if (schema.type.length > 2 || (schema.type.length > 1 && !schema.type.includes('null'))) {
// could be
if (schema.type.length > 1 && !schema.type.includes('null')) {
The first would allow type: ['integer', 'string'] which is definitely not allowed.
I've got some other notes about the way it's been tested. If those things can be resolved then I'll be happy to merge. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.