-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix buffer overflows with rDNS tags #63
Conversation
0f3bd1a
to
ee2110c
Compare
FYI, as I am mostly a Mac user, and with latest commit, binary output of rDNS tags appears identical to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks out! Thanks! 💪🏽
// https://github.com/wez/atomicparsley/issues/44 | ||
parsedAtoms[rDNS_name_atom].AtomicLength = 12; | ||
parsedAtoms[rDNS_name_atom].AtomicLength = 16; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was right the first time being initialised to 12. Otherwise you can get a buffer overrun and an invalid "name" atom written to file when the length of its value is 16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried with value 12 instead of 16 on a single file and indeed it seems to work.
Without this patch AtomicParsley on Apple Silicon native corrupts files when using
|
Resolved by #71 |
As asked,
I created this PR with a test_reverseDNS.sh script to test adding many rDNS tags to already provided issue-32.mp4.
Without this patch, there are still buffer overflows.
Corresponding ASAN report is already uploaded here: #62