Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer does not work on arm64 windows #2667

Closed
xeysz opened this issue Oct 25, 2022 · 4 comments
Closed

Installer does not work on arm64 windows #2667

xeysz opened this issue Oct 25, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@xeysz
Copy link
Contributor

xeysz commented Oct 25, 2022

What Operating System(s) are you seeing this problem on?

Windows

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

20221023-205047-43f2265e

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

Installer fails with message "This program can only be installed on versions of Windows designed for the following processor architectures: x64"

To Reproduce

Download installer and run as administrator

Configuration

no config

Expected Behavior

x64 Inno Setup should work on arm64 targets under emulation

Logs

No response

Anything else?

Windows on arm64 will emulate x64 if x64 binaries are used. The zipfile (portable) version of wezterm works fine (as far as I can tell), but the installer will refuse to run. That means users can't use winget to install or update and have to manually do both.

A native arm64 build would work but that might be more effort than getting Inno Setup to run where x64 emulation is supported.

I haven't tested on native windows arm64 installations (like a Surface Pro X), but I have access to one if that helps testing.

@xeysz xeysz added the bug Something isn't working label Oct 25, 2022
@wez
Copy link
Owner

wez commented Oct 25, 2022

Blocked on GitHub Actions not supporting arm64: actions/runner-images#768

@wez
Copy link
Owner

wez commented Oct 25, 2022

I'll accept a PR that allows the inno setup stuff to run on arm64 and allow emulation to kick in, but I have no way to validate it

@xeysz
Copy link
Contributor Author

xeysz commented Oct 26, 2022

I have a patch that works for x64 emulation on arm64. I will make sure this doesn't break native x64 and that it properly works or reports errors on older versions of windows and will send a PR your way.

@wez wez closed this as completed in 62e2e99 Nov 15, 2022
xeysz pushed a commit to xeysz/wezterm that referenced this issue Nov 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants