fix: temp fix for Android build error #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wez
reviewed
Nov 2, 2022
|
Thanks! I've published termwiz-0.19 which includes this change |
|
Wow that was quick! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
termwizcrate does not build on Android due to the lack of shared memory in the OS. The "fix" I'm proposing here is to simply panic on Android. Obviously, this is not very helpful as it still doesn't work on Android, but it's also harmless (hopefully).The reason I'm sending this PR is to make applications that only make use of other parts of
termwizwork on Android, notably Zellij:zellij-org/zellij#1833 (comment)
(Honestly I'm not entirely sure if Zellij does not use this function in question, but I've tried changing it to simply panic on any platform, and it's working for me so far on Linux)
Would be amazing if this can be merged so that we can stop using a fork for Android support.