wayland: reimplement maximize and restore

[devmatteini]

Hi!

Reimplement maximize and restore features for wayland.
It was removed with wayland reimplementation in #4777. I backported maximize and restore as before that PR was merged.

It partially fixes #6203, but I didn't check toggle_fullscreen behavior.

The only issue that I noticed is that sometimes after you invoke win:restore() wezterm window doesn't restore until you focus another application.

Configuration file for tests:

local wezterm = require "wezterm"

local config = {}

wezterm.on("gui-startup", function()
  local mux = wezterm.mux
  local tab, main_pane, main_window = mux.spawn_window {}
  main_window:gui_window():maximize()
end)

config.keys = {
  {
    key = "r",
    mods = "CTRL|SHIFT",
    action = wezterm.action_callback(function(win, pane)
      wezterm.log_info 'Restore window'
      win:restore()
    end),
  },
  {
    key = "m",
    mods = "CTRL|SHIFT",
    action = wezterm.action_callback(function(win, pane)
      wezterm.log_info 'Maximize window'
      win:maximize()
    end),
  },
}

return config

Tested on Ubuntu 24.04.1 with GNOME 46.

[wez]

Thank you!

[Felixoid]

Dear @devmatteini, it didn't fix the gap, unfortunately

[devmatteini]

@Felixoid can you share your configuration file?

I didn't have any gap while testing these changes. It might be unrelated to maximize

[Felixoid]

wezterm -n is used for tests

[devmatteini]

I can't reproduce the gap issue @Felixoid. Which linux distro and desktop environment are you using?

[wez]

That weird W icon is the fallback wayland icon that shows up when fractional scaling is used because the compositor does some kind of proxy window. In that circumstance I wouldn't be surprised if some of the metrics are out of whack.
The issue that this PR resolves is that the maximize and restore functions did nothing. They are now connected to the correct operation. I think the issue that felixoid is encountering is that the maximize function has some glitches in their environment: technically a separate issue from what was fixed here.

[devmatteini]

Thanks for the useful information! I totally agree with you