Fixed need for intercept #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 83.24% 84.16% +0.92%
==========================================
Files 18 18
Lines 1552 1554 +2
==========================================
+ Hits 1292 1308 +16
+ Misses 260 246 -14
Continue to review full report at Codecov.
|
surya-money
reviewed
Jul 18, 2022
| # Only way I found to sort is using intercept values | ||
| models.sort(key=lambda x: x[0].estimator.intercept_) | ||
| fitted.sort(key=lambda x: x[0].fold) | ||
| models, resets = list(zip(*fitted)) |
There was a problem hiding this comment.
Little bit confused by what this line does
There was a problem hiding this comment.
It's a little trick to turn a list of lists/tuples into two lists:
x = [("a", 1), ("b", 2), ("c", 3)]
y, z = list(zip(*x))
print(y)
# ["a", "b", "c"]
print(z)
# [1, 2, 3]
surya-money
reviewed
Jul 18, 2022
surya-money
approved these changes
Jul 18, 2022
sambenfredj
referenced
this pull request
in msaid-de/mokapot
Apr 12, 2023
…t' into 'develop' refactor implementation of psms streaming object Closes #62 See merge request msaid/chimerys/mokapot!51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves Issue #61 and does a little bit of cleaning in the
mokapot.brew()function.The CV fold that
mokapot.Model()objects are fit to is now recorded during the fitting process. This means we can successfully recover the order of trained models using the recorded folds.