-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parsing and retrieving SolutionGuid #26
Conversation
a3ed359
to
9be6cf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Rami for the great additions here. I love the new component which can provide the contents of a given global-section. And the introduction of a test, which checks if parsing an empty file works.
There are just somet things that I would need you to change, before I would merge this PR.
Moved sln contents to external files Simplified and refactored code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Rami for these great additions! They just helped this library immensely π
Included in version |
Thank you Martin for continuing to support this awesome library, providing valuable feedback in code reviews, accepting my contributions, and releasing a new version so quickly. β€ |
Haha thanks :) |
π« Addressed Issue(s)
Closes #23
π Description
Supports parsing and retrieving the SolutionGuid
β Checks
βΉ Additional Information