Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing and retrieving SolutionGuid #26

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

icnocop
Copy link
Contributor

@icnocop icnocop commented Aug 23, 2023

πŸ“« Addressed Issue(s)

Closes #23

πŸ“„ Description

Supports parsing and retrieving the SolutionGuid

βœ… Checks

  • My PR adheres to the general code-style of this project (look at other code if you're unsure)
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the automated tests have passed

β„Ή Additional Information

@icnocop icnocop requested a review from wgnf as a code owner August 23, 2023 23:25
@wgnf wgnf added the enhancement New feature or request label Aug 24, 2023
Copy link
Owner

@wgnf wgnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Rami for the great additions here. I love the new component which can provide the contents of a given global-section. And the introduction of a test, which checks if parsing an empty file works.

There are just somet things that I would need you to change, before I would merge this PR.

src/SlnParser.Tests/IntegrationTests.cs Outdated Show resolved Hide resolved
src/SlnParser.Tests/IntegrationTests.cs Outdated Show resolved Hide resolved
src/SlnParser/Helper/EnrichSolutionWithSolutionGuid.cs Outdated Show resolved Hide resolved
src/SlnParser/Helper/SectionParser.cs Outdated Show resolved Hide resolved
Moved sln contents to external files
Simplified and refactored code
@icnocop icnocop requested a review from wgnf August 25, 2023 08:28
Copy link
Owner

@wgnf wgnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Rami for these great additions! They just helped this library immensely πŸš€

@wgnf wgnf merged commit 227b46f into wgnf:main Aug 25, 2023
1 check passed
@wgnf
Copy link
Owner

wgnf commented Aug 25, 2023

Included in version 3.0.0 that has just been released (also see https://github.com/wgnf/SlnParser/releases/tag/v3.0.0). Thanks a lot @icnocop!

@icnocop
Copy link
Contributor Author

icnocop commented Aug 25, 2023

Thank you Martin for continuing to support this awesome library, providing valuable feedback in code reviews, accepting my contributions, and releasing a new version so quickly. ❀

@icnocop icnocop deleted the fix/23-SolutionGuid branch August 25, 2023 08:50
@wgnf
Copy link
Owner

wgnf commented Aug 25, 2023

Haha thanks :)
For appreciating my work and investing the time to help this small library out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Parse/Retrieve SolutionGuid
2 participants