This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Remove Page::is_active() #1716
Open
Remove Page::is_active() #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ip1981
force-pushed
the
ip1981/active-page
branch
from
8005720
to
6f6d250
Compare
nlinker
previously approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jgrund)
mkpankov
previously approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Reviewable status:
ip1981
force-pushed
the
ip1981/active-page
branch
from
6f6d250
to
fa1970d
Compare
mkpankov
previously approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
The purpose of this method is to prevent reloading of the current page if the same URL is clicked. But this has downsides and, probably, no value: * It is easy to forget to update this method. * Needs access to models' fields which better be private. * An opened URL is still clickable but confusingly has no effect. * There is no way to reinitialize a page other than total reload (or go to another page first). Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
ip1981
force-pushed
the
ip1981/active-page
branch
from
fa1970d
to
736dc30
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this method is to prevent reloading of the current page if
the same URL is clicked. But this has downsides and, probably, no value:
Signed-off-by: Igor Pashev pashev.igor@gmail.com
This change is