Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename permissionLevel on the transaction context #17

Closed
aaroncox opened this issue Dec 21, 2022 · 1 comment
Closed

Rename permissionLevel on the transaction context #17

aaroncox opened this issue Dec 21, 2022 · 1 comment
Milestone
0.2.x

Comments

@aaroncox
Copy link
Member

The term permissionLevel may be more complicated than needed to explain what this property is. The value of this property is actually a PermissionLevel object containing something like foobar@active, but could be either split or some other variation.

It could potentially be named something related to "Account", but the TransactContext.account will be an instance of the Account Kit. Unsure what to rename it to yet.
@aaroncox aaroncox added this to the 0.2.0 milestone Jan 10, 2023
@aaroncox
Copy link
Member Author

aaroncox commented Jan 17, 2023 •
edited
Loading

Perhaps allow specifying either permissionLevel or actor and permission?

This change can be made on both the TransactContext for plugin developers and the Session constructor to allow application developers an alternative.

The permissionLevel property on these objects can remain and be a PermissionLevel core object for those using it.

aaroncox added a commit that referenced this issue Jan 17, 2023
@aaroncox
Allow either actor + permission or permissionLevel during Session ins…
81f8bbd 
…tantiation

Fixes #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.x
Development

No branches or pull requests
1 participant
@aaroncox