Create a test passing in an ESR payload w/ meta data and ensure metadata persists #18
Milestone
Comments
aaroncox
added a commit
that referenced
this issue
Jan 17, 2023
Resolves #18. This new update method ensures the metadata from the original request will persist through modification by a `beforeSign` plugin. The original metadata will take precedent over metadata from the new request, ensuring no plugin upstream can overwrite it. A warning will be displayed when this happens to let the developer know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure if when you pass in an ESR payload, that the metadata will persist. The
createRequestmethod takes the request body and creates a newSigningRequestobject with it, which may disregard all the old information it contained.https://github.com/wharfkit/session/blob/dev/src/session.ts#L291-L321
A test should be added that passes a request with metadata, and then ensures the metadata makes it through the entire process.
If it doesn't, then perhaps we need to clone the request instead of creating a new one?
The text was updated successfully, but these errors were encountered: