Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect defaults, will try to use PGHOST if env exists and host not otherwise set #39

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

amalek215
Copy link
Collaborator

Added a verbose flag when making connection object to show connection strings tried (minus password).
Refactor connection code.
Some style changes.

Alex Malek and others added 3 commits February 22, 2023 11:01
no args in constructor will use PGHOST if it exists
added a 'verbose' flag to see what connections are being tried
Copy link
Member

@FlipperPA FlipperPA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - we reviewed this and tested it together.

@vjef
Copy link
Collaborator

vjef commented Mar 1, 2023

Changes work for me - fine to merge.

@amalek215 amalek215 merged commit d2c438b into wharton:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants