-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate if console
in partial interfaces should be mutable
#1
Comments
This basically needs implementer feedback I guess. We have two options IMO:
In both cases, the spec is currently missing definitions for the console getter/setter on window/workerglobalscope. So we should add one of those. |
I'm going to try to ask the mailing list to get implementer feedback on this one. |
cool, which mailing list exactly? would like to join the party :) |
Some browser testing results:
|
In the thread we came to two important conclusions:
I think we should work toward figuring out #3 as soon as possible. |
I rediscovered today that the spec is missing The More recently WebKit moved this into JavaScriptCore and thus no longer defines it using IDL: https://trac.webkit.org/changeset/165199 Blink and Gecko do use I don't see why this should be blocked on #3, why not just add |
Yes, given that #3 is not progressing as fast as I hoped, it seems like we should indeed just add [Replaceable] asap. Pull request? :) |
This is already the case in Blink and Gecko's IDL files: https://chromium.googlesource.com/chromium/src/+/9efd0e84a8656f4782b4526491dde8482779f06e/third_party/WebKit/Source/core/frame/Window.idl#135 https://chromium.googlesource.com/chromium/src/+/da909b2dc9c92774e21e9e6a8eb7853aa3e97834/third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl#46 https://hg.mozilla.org/mozilla-central/file/3f528e61aacf/dom/webidl/Window.webidl#l345 https://hg.mozilla.org/mozilla-central/file/ec85e0c7c060/dom/webidl/WorkerGlobalScope.webidl#l18 This issue came up when exposing the Console API to worklets: https://codereview.chromium.org/1756623002/ Fixes #1
This also makes the attributes readonly, as required by WebIDL: http://heycam.github.io/webidl/#Replaceable These changes match Blink and Gecko's IDL files: https://chromium.googlesource.com/chromium/src/+/9efd0e84a8656f4782b4526491dde8482779f06e/third_party/WebKit/Source/core/frame/Window.idl#135 https://chromium.googlesource.com/chromium/src/+/da909b2dc9c92774e21e9e6a8eb7853aa3e97834/third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl#46 https://hg.mozilla.org/mozilla-central/file/3f528e61aacf/dom/webidl/Window.webidl#l345 https://hg.mozilla.org/mozilla-central/file/ec85e0c7c060/dom/webidl/WorkerGlobalScope.webidl#l18 This issue came up when exposing the Console API to worklets: https://codereview.chromium.org/1756623002/ Fixes #1
Right now we're defining the
console
exposed to Window and WorkerGlobalScope as a type ofConsole
. In today's browsers, you'll be able to assign anything you want to theconsole
variable.This issue should determine if we want or should disallow this, and what changes need to be made to the IDL and supporting text.
The text was updated successfully, but these errors were encountered: