Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Split attachShadow element list into separate definition #1200

Merged

Conversation

dandclark
Copy link
Contributor

@dandclark dandclark commented May 18, 2023

Split the attachShadow element list into a separate definition so that it can be referenced from the EditContext spec.

See w3c/edit-context#19.


Preview | Diff

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good modulo renaming of the constant.

@mfreed7 this will impact your declarative shadow root PR (editorially) so you might want to have a look as well.

dom.bs Outdated Show resolved Hide resolved
dandclark and others added 2 commits May 18, 2023 10:09
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
dom.bs Outdated Show resolved Hide resolved
dandclark and others added 2 commits May 19, 2023 09:33
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
@annevk annevk merged commit 4b15d1f into whatwg:main May 22, 2023
@annevk
Copy link
Member

annevk commented May 22, 2023

Sigh, I did not mean to merge that with that commit message. But also doesn't seem worth it to force push to main over.

Anyway, thanks @dandclark!

Copy link
Contributor

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm late to review this, but LGTM. I can make the corresponding changes to the DSD PR once I get a chance.

@annevk annevk mentioned this pull request Oct 2, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants