-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Split attachShadow element list into separate definition #1200
Editorial: Split attachShadow element list into separate definition #1200
Conversation
… referenced from EditContext spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good modulo renaming of the constant.
@mfreed7 this will impact your declarative shadow root PR (editorially) so you might want to have a look as well.
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Sigh, I did not mean to merge that with that commit message. But also doesn't seem worth it to force push to main over. Anyway, thanks @dandclark! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm late to review this, but LGTM. I can make the corresponding changes to the DSD PR once I get a chance.
Split the attachShadow element list into a separate definition so that it can be referenced from the EditContext spec.
See w3c/edit-context#19.
Preview | Diff