Make addEventListener throw for service worker optimization #155
Conversation
|
@annevk I meant to use the following xrefs:
|
|
Ah.. I have to change a bit. The has ever been evaluated flag is not on service worker but on its script resource. Will push the change. |
jungkees
force-pushed
the
addeventlistener-fix
branch
from
ec6dd94
to
3d12c82
Compare
| @@ -1065,6 +1065,15 @@ seen from the definition above, an <a>event listener</a> is a more broad concept | |||
| method, when invoked, must run these steps: | |||
|
|
|||
| <ol> | |||
| <li> | |||
| <p>If the global object is a {{ServiceWorkerGlobalScope}} object and its associated | |||
There was a problem hiding this comment.
This should be context object's global object.
I guess doing it this way is okay. We don't need a generic solution yet. But once we do, you might have to update service workers again.
|
One other thought here, we should do this for |
jungkees
force-pushed
the
addeventlistener-fix
branch
from
3d12c82
to
77aaf40
Compare
Agreed. Addressed. The point is the event listeners should be deterministically set in the very first run. Removing one in the later runs where there's no chance to add it back seems not reasonable. I pushed the changes. |
| set, <a>throw</a> a <code>TypeError</code>. [[!SW]] | ||
|
|
||
| <p class="note no-backref">To optimize storing the event types allowed for the service worker and | ||
| to avoid non-deterministic additions of the event listeners, the user agent allows the invocation |
There was a problem hiding this comment.
s/additions of/changes to/
s/the user agent allows the invocation of the method/invocation of the method is allowed/
|
The commit message should be updated as well to account for the changes to |
To optimize storing the event types allowed for the service worker and to avoid non-deterministic changes to the event listeners, this change makes addEventListener/removeEventListener throw when it is called after the very first evaluation of the service worker script.
jungkees
force-pushed
the
addeventlistener-fix
branch
from
77aaf40
to
142f047
Compare
|
Thank you! |
|
(Had to make a few changes for bikeshed. While there I also changed a couple of things to use HTTPS.) |
|
Thanks! |
To optimize the service worker execution behavior, this change makes
addEventListener throw when it is called after the very first
evaluation of the service worker script.
SW issue: w3c/ServiceWorker#718