Skip to content

Commit

Permalink
Address review comments.
Browse files Browse the repository at this point in the history 
fix

fix

fix
  • Loading branch information
@yutakahirano
yutakahirano committed Feb 11, 2016
1 parent efd4b6b commit ea70963
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 37 deletions.
47 changes: 28 additions & 19 deletions Overview.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<p><a class="logo" href="https://whatwg.org/"><img alt="WHATWG" height="100" src="https://resources.whatwg.org/logo-fetch.svg" width="100"></a>
<h1 id="cors">Fetch</h1>
<h2 class="no-num no-toc" id="living-standard-—-last-updated-5-february-2016">Living Standard — Last Updated 5 February 2016</h2>
<h2 class="no-num no-toc" id="living-standard-—-last-updated-11-february-2016">Living Standard — Last Updated 11 February 2016</h2>

<dl>
<dt>Participate:
Expand Down Expand Up @@ -3506,16 +3506,15 @@ <h3 id="body-mixin"><span class="secno">6.2 </span>Body mixin</h3>
<a href="#concept-readablestream"><code title="concept-ReadableStream">ReadableStream</code></a> object.

<li><p>Let <var>Content-Type</var> be null.
<li><p>Let <var>action</var> be null.

<li>
<p>Switch on <var>object</var>'s type:

<dl class="switch">
<dt><a href="https://w3c.github.io/FileAPI/#blob"><code class="external" data-anolis-spec="fileapi">Blob</code></a>
<dd>
<p><a href="#concept-enqueue-readablestream" title="concept-enqueue-ReadableStream">Enqueue</a> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing a copy of <var>object</var>'s contents to
<var>stream</var>.
<p>Set <var>action</var> to an action that reads <var>object</var>.

<p>If <var>object</var>'s <a href="https://w3c.github.io/FileAPI/#dfn-type"><code class="external" data-anolis-spec="fileapi" title="dom-Blob-type">type</code></a>
attribute is not the empty byte sequence, set <var>Content-Type</var> to its value.
Expand All @@ -3524,16 +3523,16 @@ <h3 id="body-mixin"><span class="secno">6.2 </span>Body mixin</h3>
<dd>
<p><a href="#concept-enqueue-readablestream" title="concept-enqueue-ReadableStream">Enqueue</a> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing a copy of the bytes held by <var>object</var>
to <var>stream</var>.
to <var>stream</var> and <a href="#concept-close-readablestream" title="concept-close-ReadableStream">close</a>
<var>stream</var>. If that threw an exception,
<a href="#concept-error-readablestream" title="concept-error-ReadableStream">error</a> <var>stream</var> with that exception.

<dt><a href="https://xhr.spec.whatwg.org/#formdata"><code class="external" data-anolis-spec="xhr">FormData</code></a>
<dd>
<p><a href="#concept-enqueue-readablestream" title="concept-enqueue-ReadableStream">Enqueue</a> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing the result of running the
<p>Set <var>action</var> to an action that runs

This comment has been minimized.

Sign in to view

Copy link
@annevk

annevk Feb 12, 2016

Member

runs the*
<a class="external" data-anolis-spec="html" href="https://html.spec.whatwg.org/multipage/forms.html#multipart/form-data-encoding-algorithm"><code>multipart/form-data</code> encoding algorithm</a>,
with <var>object</var> as <var>form data set</var> and with
<a class="external" data-anolis-spec="encoding" href="https://encoding.spec.whatwg.org/#utf-8">utf-8</a> as the explicit character encoding, to
<var>stream</var>.
<a class="external" data-anolis-spec="encoding" href="https://encoding.spec.whatwg.org/#utf-8">utf-8</a> as the explicit character encoding.
<!-- need to provide explicit character encoding because otherwise the encoding of the
document is used -->

Expand All @@ -3545,27 +3544,37 @@ <h3 id="body-mixin"><span class="secno">6.2 </span>Body mixin</h3>

<dt><a href="https://url.spec.whatwg.org/#urlsearchparams"><code class="external" data-anolis-spec="url">URLSearchParams</code></a>
<dd>
<p><a href="#concept-enqueue-readablestream" title="concept-enqueue-ReadableStream">Enqueue</a> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing the result of running the
<a class="external" data-anolis-spec="url" href="https://url.spec.whatwg.org/#concept-urlencoded-serializer" title="concept-urlencoded-serializer"><code>application/x-www-form-urlencoded</code> serializer</a>,
with <var>object</var>'s
<a class="external" data-anolis-spec="url" href="https://url.spec.whatwg.org/#concept-urlsearchparams-list" title="concept-URLSearchParams-list">list</a>, to
<var>stream</var>.
<p>Set <var>action</var> to an action that runs

This comment has been minimized.

Sign in to view

Copy link
@annevk

annevk Feb 12, 2016

Member

runs the*
<a class="external" data-anolis-spec="url" href="https://url.spec.whatwg.org/#concept-urlencoded-serializer" title="concept-urlencoded-serializer"><code>application/x-www-form-urlencoded</code>
serializer</a> with <var>object</var>'s
<a class="external" data-anolis-spec="url" href="https://url.spec.whatwg.org/#concept-urlsearchparams-list" title="concept-URLSearchParams-list">list</a>.
<!-- utf-8 implied -->

<p>Set <var>Content-Type</var> to
`<code title="">application/x-www-form-urlencoded;charset=UTF-8</code>`.

<dt><code title="">USVString</code>
<dd>
<p><a href="#concept-enqueue-readablestream" title="concept-enqueue-ReadableStream">Enqueue</a> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing the result of running
<a class="external" data-anolis-spec="encoding" href="https://encoding.spec.whatwg.org/#utf-8-encode">utf-8 encode</a> on <var>object</var> to <var>stream</var>.
<p>Set <var>action</var> to an action that runs
<a class="external" data-anolis-spec="encoding" href="https://encoding.spec.whatwg.org/#utf-8-encode">utf-8 encode</a> on <var>object</var>.

<p>Set <var>Content-Type</var> to `<code title="">text/plain;charset=UTF-8</code>`.
</dl>

<li><p><a href="#concept-close-readablestream" title="concept-close-ReadableStream">Close</a> <var>stream</var>.
<li>
<p>If <var>action</var> is non-null, run <var>action</var> <a class="external" data-anolis-spec="html" href="https://html.spec.whatwg.org/multipage/infrastructure.html#in-parallel">in
parallel</a>:
<ol>
<li><p>Whenever one or more bytes are available, let <var>bytes</var> be the bytes and
<a href="#concept-enqueue-readablestream" title="concept-enqueue-ReadableStream">enqueue</a> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing <var>bytes</var> to <var>stream</var>. If
creating the <code>ArrayBuffer</code> threw an exception,
<a href="#concept-error-readablestream" title="concept-error-ReadableStream">error</a> <var>stream</var> with that exception
and cancel running <var>action</var>.

<li><p>When running <var>action</var> is done,
<a href="#concept-close-readablestream" title="concept-close-ReadableStream">close</a> <var>stream</var>.
</ol>

<li><p>Let <var>body</var> be a <a href="#concept-body" title="concept-body">body</a> whose
<a href="#concept-body-stream" title="concept-body-stream">stream</a> is <var>stream</var>.
Expand Down
45 changes: 27 additions & 18 deletions Overview.src.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3445,16 +3445,15 @@ <h3>Body mixin</h3>
<code title=concept-ReadableStream>ReadableStream</code> object.

<li><p>Let <var>Content-Type</var> be null.
<li><p>Let <var>action</var> be null.

<li>
<p>Switch on <var>object</var>'s type:

<dl class=switch>
<dt><code data-anolis-spec=fileapi>Blob</code>
<dd>
<p><span title=concept-enqueue-ReadableStream>Enqueue</span> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing a copy of <var>object</var>'s contents to
<var>stream</var>.
<p>Set <var>action</var> to an action that reads <var>object</var>.

<p>If <var>object</var>'s <code data-anolis-spec=fileapi title=dom-Blob-type>type</code>
attribute is not the empty byte sequence, set <var>Content-Type</var> to its value.
Expand All @@ -3463,16 +3462,16 @@ <h3>Body mixin</h3>
<dd>
<p><span title=concept-enqueue-ReadableStream>Enqueue</span> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing a copy of the bytes held by <var>object</var>
to <var>stream</var>.
to <var>stream</var> and <span title=concept-close-ReadableStream>close</span>
<var>stream</var>. If that threw an exception,
<span title=concept-error-ReadableStream>error</span> <var>stream</var> with that exception.

<dt><code data-anolis-spec=xhr>FormData</code>
<dd>
<p><span title=concept-enqueue-ReadableStream>Enqueue</span> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing the result of running the
<p>Set <var>action</var> to an action that runs
<span data-anolis-spec=html><code>multipart/form-data</code> encoding algorithm</span>,
with <var>object</var> as <var>form data set</var> and with
<span data-anolis-spec=encoding>utf-8</span> as the explicit character encoding, to
<var>stream</var>.
<span data-anolis-spec=encoding>utf-8</span> as the explicit character encoding.
<!-- need to provide explicit character encoding because otherwise the encoding of the
document is used -->

Expand All @@ -3484,27 +3483,37 @@ <h3>Body mixin</h3>

<dt><code data-anolis-spec=url>URLSearchParams</code>
<dd>
<p><span title=concept-enqueue-ReadableStream>Enqueue</span> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing the result of running the
<span data-anolis-spec=url title=concept-urlencoded-serializer><code>application/x-www-form-urlencoded</code> serializer</span>,
with <var>object</var>'s
<span data-anolis-spec=url title=concept-URLSearchParams-list>list</span>, to
<var>stream</var>.
<p>Set <var>action</var> to an action that runs
<span data-anolis-spec=url title=concept-urlencoded-serializer><code>application/x-www-form-urlencoded</code>
serializer</span> with <var>object</var>'s
<span data-anolis-spec=url title=concept-URLSearchParams-list>list</span>.
<!-- utf-8 implied -->

<p>Set <var>Content-Type</var> to
`<code title>application/x-www-form-urlencoded;charset=UTF-8</code>`.

<dt><code title>USVString</code>
<dd>
<p><span title=concept-enqueue-ReadableStream>Enqueue</span> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing the result of running
<span data-anolis-spec=encoding>utf-8 encode</span> on <var>object</var> to <var>stream</var>.
<p>Set <var>action</var> to an action that runs
<span data-anolis-spec=encoding>utf-8 encode</span> on <var>object</var>.

<p>Set <var>Content-Type</var> to `<code title>text/plain;charset=UTF-8</code>`.
</dl>

<li><p><span title=concept-close-ReadableStream>Close</span> <var>stream</var>.
<li>
<p>If <var>action</var> is non-null, run <var>action</var> <span data-anolis-spec=html>in
parallel</span>:
<ol>
<li><p>Whenever one or more bytes are available, let <var>bytes</var> be the bytes and
<span title=concept-enqueue-ReadableStream>enqueue</span> a <code>Uint8Array</code> object
wrapping an <code>ArrayBuffer</code> containing <var>bytes</var> to <var>stream</var>. If
creating the <code>ArrayBuffer</code> threw an exception,
<span title=concept-error-ReadableStream>error</span> <var>stream</var> with that exception
and cancel running <var>action</var>.

<li><p>When running <var>action</var> is done,
<span title=concept-close-ReadableStream>close</span> <var>stream</var>.
</ol>

<li><p>Let <var>body</var> be a <span title=concept-body>body</span> whose
<span title=concept-body-stream>stream</span> is <var>stream</var>.
Expand Down

0 comments on commit ea70963

Please sign in to comment.