Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-http fetch doesn't set response URL #312

Closed
Manishearth opened this issue Jun 2, 2016 · 3 comments · Fixed by #322
Closed

Non-http fetch doesn't set response URL #312

Manishearth opened this issue Jun 2, 2016 · 3 comments · Fixed by #322

Comments

@Manishearth
Copy link

XHR needs to know the response URL (https://fetch.spec.whatwg.org/#concept-response-url). However, datauri/about/etc fetches don't set it.

We should probably set the response URL in basic fetch itself.
@annevk
Copy link
Member

annevk commented Jun 3, 2016

This regressed in ed37f5e. 😟

@annevk
Copy link
Member

annevk commented Jun 3, 2016

Maybe a way to prevent further mistakes is to figure out a way to make this field immutable and set at the time we construct a response rather than this rather weird approach.

@annevk
Copy link
Member

annevk commented Jun 9, 2016

I think I should just move this back to main fetch. There's no real reason to do it locally.

annevk added a commit that referenced this issue Jun 9, 2016
@annevk
Make sure all responses have a URL list
df09f7b 
In #146 I tried to let service worker responses that were not synthetic
to keep their url list. However, the way I fixed that regressed url
lists for a number of responses: HTTP cache responses, about URL
responses, etc.

This fix instead tries to keep the old setup and only overwrites the
url list of a response if it’s empty.

Fixes #312.
@annevk annevk mentioned this issue Jun 9, 2016
Merged
annevk added a commit that referenced this issue Jun 9, 2016
@annevk
Make sure all responses have a URL list
4ecf90e 
In #146 I tried to let service worker responses that were not synthetic
to keep their url list. However, the way I fixed that regressed url
lists for a number of responses: HTTP cache responses, about URL
responses, etc.

This fix instead tries to keep the old setup and only overwrites the
url list of a response if it’s empty.

Fixes #312.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure all responses have a URL list whatwg/fetch
2 participants
@annevk @Manishearth