Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-null response body check is a no-op #343

Closed
annevk opened this issue Jul 28, 2016 · 0 comments · Fixed by #344
Closed

Non-null response body check is a no-op #343

annevk opened this issue Jul 28, 2016 · 0 comments · Fixed by #344

Comments

@annevk
Copy link
Member

annevk commented Jul 28, 2016

@yutakahirano I think with the integration of streams https://fetch.spec.whatwg.org/#concept-http-network-fetch became a little strange.

In particular, step 14 checks if response's body is non-null, but step 9 always sets it to a value. Also, step 14 sets some state on response's body to some other state that's also supposedly on response's body.

This problem stems from the fact that previously response was just an abstraction on top of HTTP, but now that works less well.

I guess the way to address it is to say that response is a hybrid between the response concept and HTTP's way of defining a response. Seems hard to solve until the layering improves.

annevk added a commit that referenced this issue Jul 28, 2016
Trailer support we can add in the future if this minimal viable
solution is a success:

* Support for synthetic responses.
* Support for (synthetic) requests.
* Trailer headers that have semantics.

Fixes #343 and fixes #34.
annevk added a commit that referenced this issue Aug 4, 2016
Trailer support we can add in the future if this minimal viable
solution is a success:

* Support for synthetic responses.
* Support for (synthetic) requests.
* Trailer headers that have semantics.

Fixes #343 and fixes #34.
annevk added a commit that referenced this issue Aug 9, 2016
Trailer support we can add in the future if this minimal viable
solution is a success:

* Support for synthetic responses.
* Support for (synthetic) requests.
* Trailer headers that have semantics.

Fixes #343 and fixes #34.
annevk added a commit that referenced this issue Aug 10, 2016
Additional trailer support we can add in the future if this minimal
viable solution (that is nonetheless complicated) is a success:

* Support for synthetic responses.
* Support for (synthetic) requests.
* Trailer headers that have semantics.
* Support for trailer headers in CORS (only for responses I think).

Fixes #34 and fixes #343.
annevk added a commit that referenced this issue Aug 10, 2016
Additional trailer support we can add in the future if this minimal
viable solution (that is nonetheless complicated) is a success:

* Support for synthetic responses.
* Support for (synthetic) requests.
* Trailer headers that have semantics.
* Support for trailer headers in CORS (only for responses I think).

Fixes #34 and fixes #343.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant