Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using entry settings object #367

Closed
annevk opened this issue Aug 11, 2016 · 7 comments
Closed

Stop using entry settings object #367

annevk opened this issue Aug 11, 2016 · 7 comments

Comments

@annevk
Copy link
Member

annevk commented Aug 11, 2016

@domenic should we just use the relevant settings object of the context object (the global object)?
@domenic domenic changed the title Stop using environment settings object Stop using entry settings object Aug 11, 2016
@domenic
Copy link
Member

domenic commented Aug 11, 2016 •
edited
Loading

(Renamed the issue for correctness.)

There are three uses:

  • Request constructor. This should use the current settings object, since there is no this to get the relevant settings object of.
  • Response constructor. Same.
  • Response.prototype.redirect. This should use the relevant settings object of the context object. (See Update guidance on relevant vs. current settings objects html#1653 for why relevant instead of current.)

@annevk
Copy link
Member Author

annevk commented Aug 11, 2016

@domenic it's Response.redirect, not on the prototype. So it's effectively a constructor. I'll make that current too.

@annevk annevk closed this as completed in 24db2d3 Aug 11, 2016
@annevk
Copy link
Member Author

annevk commented Aug 11, 2016

Thanks for the help!

@domenic
Copy link
Member

domenic commented Aug 11, 2016 •
edited
Loading

We should get web platform tests written for this, given how Chrome and Firefox are both shipping with entry... you up for it, or shall I?

@annevk
Copy link
Member Author

annevk commented Aug 11, 2016

@domenic since you can probably copy-and-paste something, you?

@domenic
Copy link
Member

domenic commented Aug 11, 2016

Yeah just was offering you the opportunity if you wanted to practice :). I'll do it.

@domenic domenic mentioned this issue Aug 11, 2016
Open
31 tasks
@wanderview
Copy link
Member

Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1432272

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 23, 2018
@wanderview
Bug 1432272 Make Fetch API use the global's base URL instead of the e…
1a6be56 
…ntry document's base URL. r=bz

The fetch spec used to use the entry settings as the base for parsing relative
Request/Response URL's, but this is no longer the case.  This was changed in:

whatwg/fetch#367

Update our code to match this behavior.  We basically convert GetEntryDocument()
to QI the global to nsGlobalWindowInner and use its ExtantDoc instead.

No changes are needed for workers since its not possible to perform cross-global
javascript access in worker threads.
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 2, 2019
@marco-c
Bug 1432272 Make Fetch API use the global's base URL instead of the e…
571cc36 
…ntry document's base URL. r=bz

The fetch spec used to use the entry settings as the base for parsing relative
Request/Response URL's, but this is no longer the case.  This was changed in:

whatwg/fetch#367

Update our code to match this behavior.  We basically convert GetEntryDocument()
to QI the global to nsGlobalWindowInner and use its ExtantDoc instead.

No changes are needed for workers since its not possible to perform cross-global
javascript access in worker threads.

UltraBlame original commit: b5432554c7bd39dd14adff8060a7f7757bb2c40e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 2, 2019
@marco-c
Bug 1432272 Make Fetch API use the global's base URL instead of the e…
c3e3ac3 
…ntry document's base URL. r=bz

The fetch spec used to use the entry settings as the base for parsing relative
Request/Response URL's, but this is no longer the case.  This was changed in:

whatwg/fetch#367

Update our code to match this behavior.  We basically convert GetEntryDocument()
to QI the global to nsGlobalWindowInner and use its ExtantDoc instead.

No changes are needed for workers since its not possible to perform cross-global
javascript access in worker threads.

UltraBlame original commit: b5432554c7bd39dd14adff8060a7f7757bb2c40e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 2, 2019
@marco-c
Bug 1432272 Make Fetch API use the global's base URL instead of the e…
2076a31 
…ntry document's base URL. r=bz

The fetch spec used to use the entry settings as the base for parsing relative
Request/Response URL's, but this is no longer the case.  This was changed in:

whatwg/fetch#367

Update our code to match this behavior.  We basically convert GetEntryDocument()
to QI the global to nsGlobalWindowInner and use its ExtantDoc instead.

No changes are needed for workers since its not possible to perform cross-global
javascript access in worker threads.

UltraBlame original commit: b5432554c7bd39dd14adff8060a7f7757bb2c40e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @wanderview @annevk