Add Last-Event-ID as CORS-safelisted request-header
#597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that you can set the Last-Event-ID request header to arbitrary values and get it across origins. That seems like sufficient reason to safelist it and hopefully make it clear to server administrators to pay extra attention to this header. Tests: ... Fixes #568.
|
Doesn’t this also need browser bugs? |
There was a problem hiding this comment.
LGTM. I preemptively updated the MDN CORS article to include this change https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS
|
Yeah, it'll need browser bugs. And I suppose it does theoretically increase the attack surface a little bit by doing this, as you'll be able to control more than just |
annevk
added
needs tests
|
This will need a new plan on top of #736. Given that I'm not sure this is still worth pursuing. |
|
Closing this, will leave the issue open for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that you can set the Last-Event-ID request header to arbitrary values and get it across origins. That seems like sufficient reason to safelist it and hopefully make it clear to server administrators to pay extra attention to this header.
Tests: ...
Fixes #568.
Preview | Diff