Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The File System Standard PR #1

Merged
merged 3 commits into from
Feb 3, 2022
Merged

The File System Standard PR #1

merged 3 commits into from
Feb 3, 2022

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 2, 2021

This turns File System Access into the File System Standard as outlined in whatwg/sg#176.

Review from @mkruisselbrink and @domenic/@foolip appreciated.


Preview | Diff

@annevk annevk mentioned this pull request Dec 3, 2021
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repo structure stuff looks good. I skimmed index.bs changes but probably @mkruisselbrink is the right reviewer for that.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
This change:

* Aligns the draft with the WHATWG boilerplate.
* Removes local file system access and the sections related to that.
* Aligns the introduction with that change in scope.
* Changes instances of and/or to or.
* Abstracts the permission model, largely to be used by dependent specifications.

See whatwg/sg#176 for context.
Copy link
Collaborator

@mkruisselbrink mkruisselbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not getting to this sooner. This all looks pretty reasonable to me.

@mkruisselbrink mkruisselbrink merged commit f520f35 into main Feb 3, 2022
@mkruisselbrink mkruisselbrink deleted the annevk/ls branch February 3, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants