-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify how "child browsing contexts" works #1336
Comments
Cannot be used for that purpose as discussed in #1337. We should also more clearly define that E has a browsing context internal slot that can be either null or a browsing context. |
I think you ended up cleaning this up, but I can't find all the commits. 7b56772 seems to be one of them. |
It looks like some of the issues were solved, but the fact that we still talk about a document's child browsing contexts or a Window's child browsing contexts remains. It should be pretty easy to clean up though now. Maybe I can give it a go soon. |
I think this is a subset of #5020. |
Basically whenever we use child browsing context in a hierarchical way there's an issue of sorts. And it would prolly make sense to give documents a child browsing context collection of sorts.
|
I just did a re-audit and, upon finishing it, realized the results are the same as your comment in #1336 (comment) . We should be able to fix the discard and abort cases pretty easily. We could leave the plugin case alone for now. And then use #5096 and #5103 to track the remaining. But, I don't think we should close this until we fix the discard and abort cases. |
As noted in #1312 (comment), current usage is ambiguous. The spec says:
i.e., it defines "browsing context C is a child browsing context of browsing context P".
Later the spec says:
In practice, how the phrase "child browsing context" is used is usually by referring to a document's child browsing contexts, or sometimes a window. This is not really well-defined.
Later in the spec when defining window.length, it says:
This concept of "child browsing contexts that are nested through elements that are in a Document" maybe is equivalent to "the document's child browsing contexts", but I am not sure. Later, in [[GetOwnProperty]] for WindowProxy, the spec uses
I'd suggest centralizing these definitions and defining:
Then an audit should be done of all places in the spec that use "child browsing context" to see if we can re-frame them in terms of one of these definitions. E.g. I think [[GetOwnProperty]] should use the Window object's child browsing contexts.
I could work on this but maybe @annevk wants to give it a shot?
The text was updated successfully, but these errors were encountered: