Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser has a case for ASCII lower alpha that should be upper alpha, I think #2375

Closed
domenic opened this issue Feb 21, 2017 · 2 comments
Closed

Parser has a case for ASCII lower alpha that should be upper alpha, I think #2375

domenic opened this issue Feb 21, 2017 · 2 comments
Labels
topic: parser

Comments

@domenic
Copy link
Member

domenic commented Feb 21, 2017

https://html.spec.whatwg.org/multipage/syntax.html#attribute-name-state:lowercase-ascii-letters

ASCII lower alpha
Append the lowercase version of the current input character (add 0x0020 to the character's code point) to the current attribute's name.

This should presumably be "ASCII upper alpha". @annevk this may have regressed in the Infra integration PR? Might be worth spot-checking a few other places in the parser...
@annevk
Copy link
Member

annevk commented Feb 21, 2017

Relevant commit: 104bd78.

@annevk
Copy link
Member

annevk commented Feb 21, 2017

Seems like the only instance from a quick skim of that section.

annevk added a commit that referenced this issue Feb 21, 2017
@annevk
Regression: ASCII lower alpha -> ASCII upper alpha in the parser
84c4fc2 
This regressed in 104bd78.

Fixes #2375.
@annevk annevk mentioned this issue Feb 21, 2017
Merged
domenic pushed a commit that referenced this issue Feb 21, 2017
@annevk @domenic
Regression fix: ASCII lower alpha → ASCII upper alpha in the parser
f1afebd 
This regressed in 104bd78.

Fixes #2375.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@annevk
Regression fix: ASCII lower alpha → ASCII upper alpha in the parser
d539734 
This regressed in 104bd78.

Fixes whatwg#2375.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: parser
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @annevk