Further BarProp cleanup

[annevk]

My assumption is that the user interface elements the BarProp talks about can be controlled via window.open(). It would be good to test if they can actually be flipped from true to false somehow and define the underlying model more clearly.

This would be a follow-up to #4430.

[annevk]

@arai-a when working on #5872 did you by any chance also look at these BarProp properties?

[arai-a]

yes, I checked the properties as well.
(testcase at https://arai-a.github.io/window-open-features/test.html shows those properties)

and yes, there's inconsistency between browsers, about which property becomes false for which condition.

the following is tested on macOS (that may affect "menubar")

Normal window (tab)

	Firefox	Safari	Chrome	Edge
locationbar.visible	true	true	true	true
menubar.visible	true	true	true	true
personalbar.visible	true	true	true	true
scrollbars.visible	true	true	true	true
statusbar.visible	true	true	true	true
toolbar.visible	true	true	true	true

Popup (with width=500)

	Firefox	Safari	Chrome	Edge
locationbar.visible	true	false	false	false
menubar.visible	false	true	false	false
personalbar.visible	false	false	false	false
scrollbars.visible	true	true	false	false
statusbar.visible	true	true	false	false
toolbar.visible	false	false	false	false

So, the values returned by Firefox and Safari almost matches the visual.

• personalbar: always hidden
• scrollbars: becomes visible if necessary
• statusbar: on Firefox, statusbar is shown as overlay if necessary. (I'm not sure if statusbar exists on Safari)
• toolbar: always hidden

Differences are:

• locationbar: shown for Firefox, hidden for Safari (so this is reasonable difference)
• menubar: in both Firefox and Safari, a popup doesn't have menu, but there's global menu at the top of screen anyway

And Chrome and Edge returns same value for all properties, just depending on whether it's popup or not.
(EDIT: this was not true. Chrome reflects the UI-related feature values, and width=500 makes them false)

Also, personalbar value doesn't reflect the actual visibility, in normal window.
Regardless of showing it or not, it returns true on normal window, and false on popup.

Then, so far, I don't think any window.open feature affects each BarProp independently.

[annevk]

Thanks, I have to say I rather like the model Chrome has, just return false for popups. Not sure we should really tell websites about what UI elements are visible or not.

[arai-a]

The Chromium behavior wasn't correct.
I'll check the behavior again and post the updated summary.

[arai-a]

on Chromium, BarProp returns UI-related features passed to window.open,
with some indirection:

• locationbar.visible: toolbar feature or location feature
• menubar.visible: menubar feature
• personalbar.visible: toolbar feature or location feature (not personalbar feature)
• scrollbars.visible: scrollbars feature
• statusbar.visible: status feature
• toolbar.visible: toolbar feature or location feature

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/bar_prop.cc;l=46-67;drc=5539ecff898c79b0771340051d62bf81649e448d;bpv=1;bpt=1

bool BarProp::visible() const {
  if (!DomWindow())
    return false;

  const WebWindowFeatures& features =
      DomWindow()->GetFrame()->GetPage()->GetWindowFeatures();
  switch (type_) {
    case kLocationbar:
    case kPersonalbar:
    case kToolbar:
      return features.tool_bar_visible;
    case kMenubar:
      return features.menu_bar_visible;
    case kScrollbars:
      return features.scrollbars_visible;
    case kStatusbar:
      return features.status_bar_visible;
  }

  NOTREACHED();
  return false;
}

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/web/web_window_features.h;l=50-55?q=tool_bar_visible&ss=chromium%2Fchromium%2Fsrc&start=11

struct WebWindowFeatures {
...
  bool menu_bar_visible = true;
  bool status_bar_visible = true;
  // This can be set based on "locationbar" or "toolbar" in a window features
  // string, we don't distinguish between the two.
  bool tool_bar_visible = true;
  bool scrollbars_visible = true;

[domenic]

Thanks! I suspect that changing the BarProp values to just follow "is popup" is not a major compat risk, but @mfreed7 is the right person to make the call.